Get tests to pass when running Julia with --compiled-modules=no
.
#114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes JuliaSIMD/LoopVectorization.jl#192 (comment) for me: Trixi's tests pass, as do ArrayInterface's after starting Julia with
--compiled-modules=no
.Normally, all functions in a module have the same world age, so the order in which generated functions are defined with respect to everything else is irrelevant. But not with
--compiled-modules=no
, which causes world age errors whenever an@generated
function calls a method defined later.I addressed this the lazy way, but just searching for all the
@generated
functions calling non-base methods and sticking them in a file at the end.We could certainly do a lot better organizationally.
@Tokazama I'm not sure why it isn't letting me request you as a reviewer.