Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all criteria structs immutable #9

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Make all criteria structs immutable #9

merged 2 commits into from
Mar 1, 2021

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 1, 2021

Also typo in one error message (PQ)

@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #9 (a6d774b) into dev (2b9a7c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          156       156           
=========================================
  Hits           156       156           
Impacted Files Coverage Δ
src/criteria.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9a7c0...a6d774b. Read the comment docs.

@ablaom ablaom merged commit c16de2b into dev Mar 1, 2021
@ablaom ablaom mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants