EarlyStopper(NumberSinceBest(3), PQ()) errors immediately

[awadell1]

julia> stopper = EarlyStopper(NumberSinceBest(3), PQ())
EarlyStopper{Disjunction{NumberSinceBest, PQ}}(Disjunction(NumberSinceBest(3), PQ(0.75, 5, 2.220446049250313e-16)), 0, #undef)

julia> done!(stopper, 1.0; training=true)
ERROR: type Nothing has no field number_since_best
Stacktrace:
 [1] getproperty(x::Nothing, f::Symbol)
   @ Base ./Base.jl:33
 [2] done(criterion::NumberSinceBest, state::Nothing)
   @ EarlyStopping ~/.julia/packages/EarlyStopping/O3BIV/src/criteria.jl:360
 [3] _done
   @ ~/.julia/packages/EarlyStopping/O3BIV/src/disjunction.jl:68 [inlined]
 [4] _done
   @ ~/.julia/packages/EarlyStopping/O3BIV/src/disjunction.jl:71 [inlined]
 [5] done(d::Disjunction{NumberSinceBest, PQ}, state::NamedTuple{(:a, :b), Tuple{Nothing, EarlyStopping.PQState{Float64}}})
   @ EarlyStopping ~/.julia/packages/EarlyStopping/O3BIV/src/disjunction.jl:74
 [6] done(stopper::EarlyStopper{Disjunction{NumberSinceBest, PQ}})
   @ EarlyStopping ~/.julia/packages/EarlyStopping/O3BIV/src/object_oriented_api.jl:44
 [7] done_after_update_training!(stopper::EarlyStopper{Disjunction{NumberSinceBest, PQ}}, loss::Float64)
   @ EarlyStopping ~/.julia/packages/EarlyStopping/O3BIV/src/object_oriented_api.jl:59
 [8] done!(stopper::EarlyStopper{Disjunction{NumberSinceBest, PQ}}, loss::Float64; training::Bool)
   @ EarlyStopping ~/.julia/packages/EarlyStopping/O3BIV/src/object_oriented_api.jl:69
 [9] top-level scope
   @ REPL[11]:1

Issues apears to be:

• update_training(::NumberSinceBest, loss) dispatches to update_training(::StoppingCriterion, loss) = nothing
• done(::NumberSinceBest, ::Nothing)` dispatches to ln 360 in src/criteria.jl -> which promptly errors out

Related to #5 but not caught by stopping_time, which check if training before calling done(criteria, state)

I can take a stab at fixing this / adding in new tests tomorrow

Best,

Alex

[ablaom]

Great catch and diagnosis!

I can take a stab at fixing this / adding in new tests tomorrow

That would be awesome.