Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient direction changed after leaving app #149

Closed
kimsonwong opened this issue Apr 30, 2019 · 6 comments
Closed

Gradient direction changed after leaving app #149

kimsonwong opened this issue Apr 30, 2019 · 6 comments
Assignees

Comments

@kimsonwong
Copy link

⚠️ Please fill out this template when filing an issue.

🙏🏼 Please check if it already exists other issue related with yours.

What did you do?

I made this view with top to bottom gradient. This is what I used to create gradient:

let gradient = SkeletonGradient.init(baseColor: color_262626, secondaryColor: color_4B4B4B)
let animation = SkeletonAnimationBuilder().makeSlidingAnimation(withDirection: .topBottom)
skeletonView.isSkeletonable = true
skeletonView.showAnimatedGradientSkeleton(usingGradient: gradient, animation: animation)

What did you expect to happen?

When I leave the app or go to app switcher and go back to my app I expect the gradient to be the same because I did not update it in any way.

What happened instead?

Instead of staying the same gradient direction, it changed from top to bottom, to left to right.

Steps to reproduce the behavior

Video attached.

SkeletonView Environment

SkeletonView 1.5
Xcode 10.1 (10B61)
Swift 3

skeleton gradient issue

@Juanpe
Copy link
Owner

Juanpe commented Apr 30, 2019

Thanks @kimsonwong for report this bug. It will fixed soon :)

@FeedMyTummy
Copy link

I have the issue that when I use it in a tab view switch out and switch back, the animation stops. Anyway to prevent this?

@danqing
Copy link

danqing commented Aug 16, 2019

To add to @FeedMyTummy, for me not only does the animation stop, the skeleton view looks pretty strange (not a solid color).

@Juanpe do you know if this and the issue reported by OP are the same? It sounds like you already have an idea of what might have gone wrong? I believe this is also related to (much older) #88.

IMG_26EC07CB83C7-1

@Juanpe Juanpe self-assigned this Aug 23, 2019
@danqing
Copy link

danqing commented Aug 25, 2019

FWIW, after upgraded to 1.8, I always see the above, even on the first load..

@Juanpe
Copy link
Owner

Juanpe commented Aug 25, 2019

Thanks @danqing, I’m working on this bug, I hope release a patch soon 🤙🏼

@Juanpe
Copy link
Owner

Juanpe commented Aug 26, 2019

Hi!

This bug has been fixed in version 1.8.1

Thanks for reporting this bug and for use SkeletonView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants