-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set timeout param for iOS as nonnull instead of nullable, as React requires #397
Conversation
… all NSNumber arguments are nonnull
Hi @DavideViolante and sorry for delay :) I think the suggested modification is correct, but i don't have time to test it, have you tested it? |
I didn't test it actually, I just noticed a couple of issues with same error since latest version and tried to fix it. |
Actually, i am using the 0.72.3 version of react-native. Maybe the newest version is causing the problem? |
I can't test it at the moment. but if you test it and works I will merge it |
This fixed the error on my end once I added the 5th parameter to my call to |
Thank you for testing. I updated readme too. |
@DavideViolante Agree, but don't wait for me :) |
I can't merge by myself |
Thank you for the collaborator invite. |
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fix #396
Fix #379
I honestly don't know if this is correct, I used this conversation with ChatGPT to help me fix this error.
This PR absolutely requires at least one review from someone that know this code and language.
cc @JuanSeBestia @alexma01