Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set timeout param for iOS as nonnull instead of nullable, as React requires #397

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

DavideViolante
Copy link
Collaborator

Fix #396
Fix #379

I honestly don't know if this is correct, I used this conversation with ChatGPT to help me fix this error.

This PR absolutely requires at least one review from someone that know this code and language.

cc @JuanSeBestia @alexma01

@alexma01
Copy link
Contributor

Hi @DavideViolante and sorry for delay :)

I think the suggested modification is correct, but i don't have time to test it, have you tested it?

@DavideViolante
Copy link
Collaborator Author

I didn't test it actually, I just noticed a couple of issues with same error since latest version and tried to fix it.
@JuanSeBestia can you check this PR out please?

@alexma01
Copy link
Contributor

Actually, i am using the 0.72.3 version of react-native. Maybe the newest version is causing the problem?

@JuanSeBestia
Copy link
Owner

I can't test it at the moment. but if you test it and works I will merge it

@keith-kurak
Copy link

This fixed the error on my end once I added the 5th parameter to my call to connectToProtectedSSID. (updating the readme, as well, would probably be good)

@DavideViolante
Copy link
Collaborator Author

DavideViolante commented Sep 11, 2024

Thank you for testing. I updated readme too.
I'd merge this one @JuanSeBestia

@JuanSeBestia
Copy link
Owner

@DavideViolante Agree, but don't wait for me :)

@DavideViolante
Copy link
Collaborator Author

I can't merge by myself

@JuanSeBestia JuanSeBestia merged commit 737111b into JuanSeBestia:master Sep 12, 2024
1 check passed
@DavideViolante
Copy link
Collaborator Author

Thank you for the collaborator invite.
Can you please create a new release or tell me how do you usually do it with semantic-release bot (I never used it), thanks.

@JuanSeBestia
Copy link
Owner

🎉 This PR is included in version 4.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants