add location permission check for getCurrentWifiSSID and reScanAndLoa… #264
Conversation
…dWifiList and change error message for clarity
|
👏 Thanks for your contribution! |
| @@ -576,4 +568,20 @@ private void stuffWifiConfigurationWithoutEncryption(final WifiConfiguration wif | |||
| private String formatWithBackslashes(final String value) { | |||
| return String.format("\"%s\"", value); | |||
| } | |||
|
|
|||
| private boolean isLocationPermissionGranted(final Promise promise) { | |||
There was a problem hiding this comment.
Not a 100% fan of the method name, as this method does the check and rejects the promise, which isn't clear now.
There was a problem hiding this comment.
maybe rejectIfLocationPermissionMissing or assertLocationPermissionGranted?
|
This patch looks good @eliaslecomte – are there any concerns about merging? |
|
@JuanSeBestia looks good to me, can this be merged and published? |
|
Looks like in Android 13 you can request |
## [4.7.1](v4.7.0...v4.7.1) (2023-05-26) ### Bug Fixes * **Android:** * add location permission check for getCurrentWifiSSID and reScanAndLoadWifiList and change error message for clarity ([#264](#264)) ([c3ba4e5](c3ba4e5))
|
🎉 This PR is included in version 4.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I squash and rename to fix(Android): add location permission check for getCurrentWifiSSID and reScanAndLoadWifiList and change error message for clarity because semantic commits is needed to release a new version |
|
Thanks @JuanSeBestia for merging this & doing a release 🎉. |
* master_new: chore(asdf): add a .tool-versions for asdf, set node to 16.18.0 and update package-lock files chore(release): 4.8.3 [skip ci] fix(iOS): add missing isHidden flag to connectToProtectedSSID (JuanSeBestia#306) chore(release): 4.8.2 [skip ci] fix: prefer not to mutate the ScanResult object (JuanSeBestia#268) chore(release): 4.8.1 [skip ci] fix: update android native dependencies chore(release): 4.8.0 [skip ci] feat(Android): added feature to connect to hidden wifi on android 10 (JuanSeBestia#287) chore(release): 4.7.1 [skip ci] fix(Android): * add location permission check for getCurrentWifiSSID and reScanAndLoadWifiList and change error message for clarity (JuanSeBestia#264)
Fix : #257 , #265 , #258 and clarify #238