fix(iOS): Fix disconnectFromSSID having no effect #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested locally for iOS 15 on a wifi network that the app configured and calling disconnect directly works. But with the `getConfiguredSSIDsWithCompletionHandler` it does not. This is an alternative PR to this one where I know it won't work but at least we get an error message out of it: #213
|
@scarlac, thank you for your PRs. I believe this one is the one to merge as it fixes the functionality provided by the method. |
Rapsssito
changed the title
JuanSeBestia
pushed a commit
that referenced
this pull request
Nov 4, 2021
## [4.4.1](v4.4.0...v4.4.1) (2021-11-04) ### Bug Fixes * **Android:** Replace jCenter with mavenCentral ([#216](#216)) ([b047208](b047208)) * **iOS:** Fix disconnectFromSSID having no effect ([#214](#214)) ([0d55c08](0d55c08)) * **iOS:** Fix prefix check in connectToProtectedSSIDPrefix ([#220](#220)) ([d94f356](d94f356))
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
I tested locally for iOS 15 on a wifi network that the app configured and calling disconnect directly works. But with the
getConfiguredSSIDsWithCompletionHandlerit does not.This is an alternative to: #213