Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): Add elvis dependency to build.gradle #152

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix(Android): Add elvis dependency to build.gradle #152

merged 1 commit into from
Jan 7, 2021

Conversation

eliaslecomte
Copy link
Collaborator

@eliaslecomte eliaslecomte commented Jan 7, 2021

To fix the dependency bug reported here: #142 we can add 'com.thanosfisherman.elvis:elvis:3.0' in the libs build.gradle for now.

I'll follow up with WifiUtils. On some devices there are no problems (Samsung S10) and on others there are (OnePlus NORD) so I think it might be cpu architecture related.

Fixes #142

@Rapsssito Rapsssito changed the title Fix(android): Add elvis dependency in our build.gradle. fix(Android): Add elvis dependency to build.gradle Jan 7, 2021
@Rapsssito Rapsssito merged commit 1ab284a into JuanSeBestia:master Jan 7, 2021
JuanSeBestia pushed a commit that referenced this pull request Jan 7, 2021
## [4.3.5](v4.3.4...v4.3.5) (2021-01-07)

### Bug Fixes

* **Android:** Add elvis dependency to build.gradle ([#152](#152)) ([1ab284a](1ab284a))
@JuanSeBestia
Copy link
Owner

🎉 This PR is included in version 4.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eliaslecomte eliaslecomte deleted the feature/dependency-bug branch January 8, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken dependencies
3 participants