fix: prefer not to mutate the ScanResult object #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@eliaslecomte You are maintainer of this project, feel free to merge any feature that's you want |
JuanSeBestia
pushed a commit
that referenced
this pull request
May 26, 2023
## [4.8.2](v4.8.1...v4.8.2) (2023-05-26) ### Bug Fixes * prefer not to mutate the ScanResult object ([#268](#268)) ([840c80d](840c80d))
|
🎉 This PR is included in version 4.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
timok06
added a commit
to enna-systems/react-native-wifi-reborn
that referenced
this pull request
Aug 4, 2023
* master_new: chore(asdf): add a .tool-versions for asdf, set node to 16.18.0 and update package-lock files chore(release): 4.8.3 [skip ci] fix(iOS): add missing isHidden flag to connectToProtectedSSID (JuanSeBestia#306) chore(release): 4.8.2 [skip ci] fix: prefer not to mutate the ScanResult object (JuanSeBestia#268) chore(release): 4.8.1 [skip ci] fix: update android native dependencies chore(release): 4.8.0 [skip ci] feat(Android): added feature to connect to hidden wifi on android 10 (JuanSeBestia#287) chore(release): 4.7.1 [skip ci] fix(Android): * add location permission check for getCurrentWifiSSID and reScanAndLoadWifiList and change error message for clarity (JuanSeBestia#264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple java change; don't mutate the ScanResults, just populate the WritableNativeArray correctly.