fix(iOS): Revert wrong removal of promise resolution #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scarlac can you also have a look at this? |
scarlac
approved these changes
Dec 3, 2021
|
@JuanSeBestia would you mind approving? |
Rapsssito
changed the title
JuanSeBestia
pushed a commit
that referenced
this pull request
Dec 16, 2021
## [4.4.2](v4.4.1...v4.4.2) (2021-12-16) ### Bug Fixes * **iOS:** Revert wrong removal of promise resolution ([#225](#225)) ([89eda2d](89eda2d))
|
🎉 This PR is included in version 4.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #214 a bug was fixed regarding
disconnectFromSSIDhaving no effect. However, I'm pretty sure theresolve(nil)was wrongly removed. In our code, the promise now never resolves.This PR reverts that unwanted deletion and makes sure the (JS) promise resolves.
Tested with our code.