Skip to content

Commit

Permalink
Remove test check from pre-push git hooks and add linters in ci (#61)
Browse files Browse the repository at this point in the history
* ci: remove test check from pre-push git hooks

* style: fix code formatting

* fix: change dependabot package-ecosystem to npm

* ci: check containers default versioning

* ci:  add linters in GH pipeline
  • Loading branch information
Jozwiaczek authored Feb 18, 2021
1 parent 8373e42 commit ea9cf60
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 19 deletions.
18 changes: 10 additions & 8 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ about: Create a report to help us improve
title: '[Bug report]:'
labels: 'bug'
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -24,15 +24,17 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ about: Suggest an idea for this project
title: '[Feature request]:'
labels: 'enhancement'
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
Expand Down
12 changes: 6 additions & 6 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
version: 2
updates:
- package-ecosystem: "yarn"
directory: "/"
- package-ecosystem: 'npm'
directory: '/'
schedule:
interval: "monthly"
day: "friday"
time: "16:00"
timezone: "Europe/Warsaw"
interval: 'monthly'
day: 'friday'
time: '16:00'
timezone: 'Europe/Warsaw'
10 changes: 7 additions & 3 deletions .github/workflows/continous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ env:
jobs:
Validate:
name: 'Validate Pull Request'
timeout-minutes: 5
timeout-minutes: 10
runs-on: ubuntu-latest
container: node:12.19.1-alpine3.10
container: node
env:
DB_PORT: 5432
DB_HOST: postgres
Expand All @@ -18,7 +18,7 @@ jobs:
DB_DATABASE_TEST: smart_gate_db_test
services:
postgres:
image: postgres:10.12-alpine
image: postgres
env:
POSTGRES_PASSWORD: postgres_password
options: >-
Expand All @@ -38,6 +38,10 @@ jobs:
run: yarn install --frozen-lockfile
- name: 'Audit dependencies'
run: /bin/sh -c 'yarn audit --level high; [[ $? -ge 8 ]] && exit 1 || exit 0'
- name: 'Run Prettier'
run: yarn prettier
- name: 'Run ESLint'
run: yarn lint
- name: 'Setup test database'
run: yarn ci:setup:db
- name: 'Run unit tests'
Expand Down
1 change: 0 additions & 1 deletion .huskyrc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
hooks: {
'pre-commit': 'yarn type-check && lint-staged',
'pre-push': 'yarn test && yarn test:e2e',
'commit-msg': 'commitlint -E HUSKY_GIT_PARAMS',
},
};

0 comments on commit ea9cf60

Please sign in to comment.