Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Council spending budget #1628

Closed

Conversation

ondratra
Copy link
Contributor

Spending budget(s) and periodic rewards for council members.

Fixes #1305 and #1487.

@ondratra
Copy link
Contributor Author

ondratra commented Nov 5, 2020

At this point, this PR fixes #1305 in full. All budget's features needed for #1487 are implemented, but the actual spending for working groups and proposals purposes is missing and will need to be discussed before connecting to related modules (working_group and proposals).

@ondratra ondratra marked this pull request as ready for review November 5, 2020 09:47
@ondratra ondratra force-pushed the council_spending_budget branch from 07c3d17 to 039e26c Compare November 13, 2020 20:43
@bedeho
Copy link
Member

bedeho commented Nov 16, 2020

This implementation has lots of things in it which are hard to connect to anything described anywhere, not least of which that it has a new standalone module.

  1. Please elaborate on what happened here.
  2. At this point I think its just best to start a new PR fresh which directly implements Integrated budget constraints #1487 in as similar a way as the working_team pallet https://github.com/Joystream/joystream/tree/working_team_pallet/runtime-modules/working-team/src . If you are at all uncertain about what that would entail, provide a new issue with a sketch of what you have in mind, and I can review it before you implement anything.

@ondratra
Copy link
Contributor Author

Closed in favor of #1760.

@ondratra ondratra closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants