Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a different Kind for Fragment Arguments #13

Conversation

yaacovCR
Copy link
Collaborator

at least for now!

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock
Copy link
Owner

I guess we'll need to refactor both the execution and validation PR's if we add this in, right?

@yaacovCR
Copy link
Collaborator Author

I guess we'll need to refactor both the execution and validation PR's if we add this in, right?

Yes, but should be pretty straight forward. I can take a stab at it over the weekend…. Maybe over the weekend…

@JoviDeCroock JoviDeCroock merged commit c3f01bd into JoviDeCroock:fragment-args-syntax-2024 Aug 29, 2024
15 of 16 checks passed
@yaacovCR yaacovCR deleted the fragment-argument-kind branch September 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants