Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript Contribution Diary: Filtering Out Types From JavaScript-Only Import Suggestions #112

Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 16, 2023

PR Checklist

Overview

Describes how microsoft/TypeScript#53619 came to be (merged). FYI @Andarist @sandersn, you feature a bit 🙂

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joshuakgoldberg-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 10:46pm

@sandersn
Copy link

No specific comments, but I love the step-by-step explanation of how to make a change to Typescript. It is great for helping new contributors figure out how to get started.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4a96c90 into main Nov 20, 2023
11 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the article-filter-out-types-from-js-only-import-suggestions branch November 20, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Article: TypeScript Contributing Diary on Filtered out types from import suggestions in JS files #53619
2 participants