Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sub-spinner labels for some spinner task groups #710

Merged
merged 12 commits into from
Aug 26, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 26, 2023

PR Checklist

Overview

For some longer-running spinners that had multiple sub-tasks, adds a new withSpinners function that takes in an array of labeled tasks. The CLI output for that one shows the list of completed tasks & running task under the parent group, then clears that list once it's done.

Screen.Recording.2023-08-26.at.2.17.08.PM.mov

@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to npx-y-all-contributors-cli August 26, 2023 18:09
Base automatically changed from npx-y-all-contributors-cli to main August 26, 2023 18:32
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: added logging for some sub-groups feat: added sub-spinner labels for some spinner task groups Aug 26, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 26, 2023 19:20
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #710 (db326c1) into main (b2bb360) will increase coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 95.54%.

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   90.85%   91.02%   +0.16%     
==========================================
  Files          79       80       +1     
  Lines        3818     3946     +128     
  Branches      208      216       +8     
==========================================
+ Hits         3469     3592     +123     
- Misses        348      353       +5     
  Partials        1        1              
Flag Coverage Δ
create 72.68% <67.51%> (-0.01%) ⬇️
initialize 33.72% <69.42%> (+1.33%) ⬆️
migrate 73.32% <75.79%> (+0.24%) ⬆️
unit 34.14% <0.00%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/shared/cli/spinners.ts 83.09% <85.71%> (+7.23%) ⬆️
src/create/createWithOptions.ts 70.42% <100.00%> (+4.84%) ⬆️
src/initialize/initializeWithOptions.ts 79.36% <100.00%> (+3.89%) ⬆️
src/migrate/migrateWithOptions.ts 76.47% <100.00%> (+9.80%) ⬆️
src/shared/cli/lines.ts 100.00% <100.00%> (ø)
src/shared/cli/startLineWithDots.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit dc634e6 into main Aug 26, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the verbose-logging branch August 26, 2023 19:43
@github-actions
Copy link

🎉 This is included in version v1.29.8 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add verbose logging
1 participant