Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dind test to validate docker build #94

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Add dind test to validate docker build #94

merged 8 commits into from
Nov 18, 2024

Conversation

JoshuaC215
Copy link
Owner

@JoshuaC215 JoshuaC215 commented Nov 17, 2024

  • Add an optional "fake" model which always returns the same answer
  • Add a /health check endpoint to the service
  • Add an integration test that assumes the service is running in docker
  • Add a step in the test-docker.yml workflow to actually run the containers using dind, confirm the health checks pass, and run the integration test on the service (note: it doesn't actually execute the streamlit app to confirm it loads)

@JoshuaC215 JoshuaC215 marked this pull request as ready for review November 18, 2024 01:27
@JoshuaC215 JoshuaC215 merged commit aaf914d into main Nov 18, 2024
4 checks passed
@JoshuaC215 JoshuaC215 deleted the add-dind-test branch November 18, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant