Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed inheritance from Nette\Object and added trait Nette\SmartObject #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aplitax
Copy link

@aplitax aplitax commented May 16, 2018

removed inheritance from Nette\Object
added trait Nette\SmartObject

added trait Nette\SmartObject
@castamir
Copy link
Member

castamir commented May 16, 2018

Hi!
Thanks for your PR.

This change is not compatible with old PHP version. So to merge it, we need to set minimal supported version to PHP 5.6 or PHP 7+.

So, can you also upgrade composer.json and travis.yml to get rid of those old PHP versions?

{
use \Nette\SmartObject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 5 spaces instead of 4

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants