Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment handling in async version #16

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

MonoidMusician
Copy link
Contributor

The sync version was using the parsed env correctly, but it didn't make it into the async version which meant that extendEnv did not work when env was set.

To reproduce:

execa "env" [] _ { env = Just mempty, extendEnv = Just true }

would return only

NODE_CHANNEL_FD=3
NODE_CHANNEL_SERIALIZATION_MODE=json

Copy link
Owner

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch!

@JordanMartinez JordanMartinez merged commit aca4fc9 into JordanMartinez:master Sep 8, 2023
@JordanMartinez
Copy link
Owner

There's a number of other differences with execaSync that should also be updated. I'll push a fix for those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants