-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: theme toggle each time content script is loaded #835
Fix: theme toggle each time content script is loaded #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. We will check and reply to you as soon as possible.
@tr4cks You've forgoten to run |
cf092f8
to
1213268
Compare
is it normal that the update also affected another line? From:
To:
Other lines have been modified, but they also concern the same thing. Let me know if I leave it the way it was or update that too. Thanks |
@tr4cks Probably it have I'm not very sure about that, but that's probably it, but after all, run |
1213268
to
39a7e4e
Compare
39a7e4e
to
6b3549c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Priority*
Purpose of the PR*
Make sure the theme doesn't change every time the content script is loaded into a page. This can be a bit confusing the first time you test the project.
Changes*
I removed the
toggleTheme()
function in the content script and the dependency inpackage.json
. I added an external function to still show an example of how to define functions in an external module.How to check the feature
Open the extension's side panel and then search in the browser's search bar. The theme no longer changes every time you change pages (when the content script is loaded).