Rune e2e tests on stable browser release channel #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govza
force-pushed
the
wdio-fixes
branch
5 times, most recently
from
4a61438 to
f438535
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are passing on stable and beta chrome, but we test on latest canary and looks like that's an issue.
Also noticed small issue with formatting in getMessageFromLocale.ts
Priority*
Purpose of the PR*
Fix failing pipeline, fix eslint/prettier conflicting with generated code
Changes*
How to check the feature
Pipeline tests should be passing
Adding more languages doesn't conflict with prettier formatting in the getMessageFromLocale.ts
Reference