Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify update-version package script #752

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I want to simplify it, because i've created it more complicated than it can be, as you can see

Changes*

I've removed run-os-script package and simplify update-version script

How to check the feature

Run pnpm update-version 0.2.2

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo enabled auto-merge (squash) September 22, 2024 05:23
@Jonghakseo Jonghakseo merged commit 2d65c69 into main Sep 22, 2024
7 checks passed
@Jonghakseo Jonghakseo deleted the chore/simplify-update-version-script branch September 22, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants