Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vite config types error #704

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I need to clean up my own mess :)
There's need to unify versions between packages, to have no errors on vite.config.mts of chrome-extension package

Changes*

I've unified versions of root and chrome-extension package.json

How to check the feature

Run e.g pnpm lint, and check it runs

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrome-extension/package.json Outdated Show resolved Hide resolved
@PatrykKuniczak PatrykKuniczak force-pushed the fix/error-of-vite-configs branch from 9d64a86 to c6126c6 Compare September 6, 2024 10:40
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrykKuniczak PatrykKuniczak merged commit a8a0abf into main Sep 6, 2024
4 checks passed
@PatrykKuniczak PatrykKuniczak deleted the fix/error-of-vite-configs branch September 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants