Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/refactor-all-packages-json #697

Merged
merged 19 commits into from
Sep 5, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Sep 3, 2024

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I want to do it in more turbo friendly way, and i've done it as simply as possible for now.

Changes*

I've split clean command and remove redundancy from dev

I've used pnpx for avoid cases when users run pnpm clean:turbo and then want to run pnpm clean:node_modules or clean

By this move i want to avoid a bunch of issues about new error(users reports) 😆

I've also removed tasks from dependsOn due to lack of opportunities to define a order, in package.json i can do it freely.
Maybe in the future we'll find a better solution for that.

And also don't pay attension to cross-env because it works for now, and i'll try to refactor it, to looks and works better 😄

How to check the feature

Run new and old commands, and check if it works

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

packages/i18n/package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@PatrykKuniczak PatrykKuniczak force-pushed the chore/refactor-all-packages-json branch from f6423fc to 2743f9b Compare September 5, 2024 06:54
@PatrykKuniczak PatrykKuniczak linked an issue Sep 5, 2024 that may be closed by this pull request
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrykKuniczak PatrykKuniczak merged commit 76d23b4 into main Sep 5, 2024
4 checks passed
@PatrykKuniczak PatrykKuniczak deleted the chore/refactor-all-packages-json branch September 5, 2024 07:12
@plbstl plbstl mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base.package.json for simplify package.json in all modules (DRY)
2 participants