-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/refactor-all-packages-json #697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonghakseo
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Jonghakseo
reviewed
Sep 5, 2024
…bo.json dependsOn`
…s from `turbo.json clean`
…urbo.json dependsOn`
f6423fc
to
2743f9b
Compare
Jonghakseo
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priority*
Purpose of the PR*
I want to do it in more
turbo
friendly way, and i've done it as simply as possible for now.Changes*
I've split
clean
command and remove redundancy fromdev
I've used
pnpx
for avoid cases when users runpnpm clean:turbo
and then want to runpnpm clean:node_modules
orclean
By this move i want to avoid a bunch of issues about new error(users reports) 😆
I've also removed tasks from
dependsOn
due to lack of opportunities to define a order, inpackage.json
i can do it freely.Maybe in the future we'll find a better solution for that.
And also don't pay attension to
cross-env
because it works for now, and i'll try to refactor it, to looks and works better 😄How to check the feature
Run new and old commands, and check if it works