-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export module error #683
Conversation
Removing the module brings back the below error: |
@akshaycj I've figured it out, a minutes ago XD I need to take a look on that, i've placed it on my TODO list, i'll fixed it ASAP :) |
@PatrykKuniczak quick question, what parts of the extension are affected when module is added? just curious. |
@akshaycj If my brain works well, that's probably Maybe that's conflict with sth else, and it distract me, and the solution could be to rollback this PR. |
@akshaycj Sth like that ocurr: I don't want to struggle with this, i'll create new package for handle all env and simplify it for users 🔥 |
I'm struggling a lot with this |
I'm currently working on new solution, i have som bash script for automatization and now process.env have all envs including this from CLI. But i can't use Be pacient, we'll merge it ASAP 😄 |
That's awesome to know, thank you very much @PatrykKuniczak |
@paluchi But I'm verrryyy stuck with 1 think and we all were stuck, but i hope i'll do it in this week :) |
Maybe it works for us. |
@Jonghakseo @PatrykKuniczak At least from my side I can say you are helping a lot of people fixing this issue. I'm trying to centralize envs in a .ts file under packages directory but It seems not to work with process.env nor import.meta.env.{YOUR_KEY} |
I had to remove this line to get it working but even then, I get ts error saying
![]() Let me try to fix this. |
it turned out that it refers to so basically,
|
I'll do it to work everywhere good, but after we merge #711 :) |
Hi @PatrykKuniczak. Is there any time estimate for the resolution of this problem? |
It depends on @Jonghakseo time, because i have been waiting for code review |
Hi @PatrykKuniczak @Jonghakseo Do we have any news regarding this problem? |
We have no time |
Priority*
Purpose of the PR*
On the #682 i changed this value, because one person from discord suggest it, but it isn't good idea, because i see a part of pages don't work properly, we need to change it immediately.
Changes*
I removed
module
fromtsconfig
This it very urgent :)