Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/simplify hmr #656

Merged
merged 19 commits into from
Aug 18, 2024
Merged

chore/simplify hmr #656

merged 19 commits into from
Aug 18, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I want to simplify and remove unnecessary thinks from hmr module

Changes*

I moved some files to folders.
I added max reconnecting tries on initializeWebSocket
I cleaned code a little.
And a little more, let's take a look

How to check the feature

Nothing changed for facilities.

@PatrykKuniczak
Copy link
Collaborator Author

That's became, when i was trying to solve #477 😆

@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Aug 15, 2024
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@PatrykKuniczak PatrykKuniczak merged commit 1505aa3 into main Aug 18, 2024
4 checks passed
@PatrykKuniczak PatrykKuniczak deleted the chore/refactor-hmr branch August 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants