scubainit: Restore the default SIGPIPE action #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files 6 suites 2m 5s ⏱️ Results for commit 3ddfaf5. ♻️ This comment has been updated with latest results. |
JonathonReinhart
force-pushed
the
254-scubainit-SIGPIPE
branch
from
bbd1ede to
d405167
Compare
haboustak
reviewed
May 20, 2024
JonathonReinhart
force-pushed
the
254-scubainit-SIGPIPE
branch
from
d405167 to
e15af52
Compare
Rust pre-main code may change the SIGPIPE disposition to ignore: * rust-lang/rust#62569 * rust-lang/rust#97889 We could use the nightly compiler flag -Zon-broken-pipe=inherit to disable this behavior. Instead, we take the simpler route and restore the default disposition ourselves. Fixes #254
JonathonReinhart
force-pushed
the
254-scubainit-SIGPIPE
branch
from
e15af52 to
3ddfaf5
Compare
|
This was just released in v2.13.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust pre-main code may change the SIGPIPE disposition to ignore:
unix_sigpiperust-lang/rust#97889We could use the nightly compiler flag
-Zon-broken-pipe=inheritto disable this behavior. Instead, we take the simpler route and restore the default disposition ourselves.Fixes #254