Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python versions #1382

Open
wants to merge 3 commits into
base: dev-v1.0
Choose a base branch
from

Conversation

cnheitman
Copy link
Collaborator

This PR updates the Python versions of some of the CI, and drops support for Python 3.8 as the end of life was 2024-10-07.

@mrexodia
Copy link
Contributor

Isn't it a bit early to drop support for 3.8, it's been 2 months 😅

@cnheitman
Copy link
Collaborator Author

Hey! Too early? 😅

Keep in mind this change only affects the CI. No change was made to the code, so it still builds for Python 3.8 locally.

Mostly, it is for simplifying the maintenance, as we already support 5 versions of Python.

I could postpone this change if necessary. Are you aware of anyone affected too much by this change?

@mrexodia
Copy link
Contributor

I opened #1383, which would solve this issue once and for all (more as an fyi). As for the impact, it would remove the binary wheels for python 3.8 from pypi right?

@cnheitman
Copy link
Collaborator Author

I opened #1383, which would solve this issue once and for all (more as an fyi).

Thanks, I've just replied to your issue.

As for the impact, it would remove the binary wheels for python 3.8 from pypi right?

Yes, in principle, I will stop pushing the py38 wheel to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants