-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add effort directive #618
Conversation
🦋 Changeset detectedLatest commit: 21bf449 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e14e856
to
ab3b1fd
Compare
ab3b1fd
to
7c0a4b9
Compare
7c0a4b9
to
7752c28
Compare
Covers platform difference between mac and linux (sharp#3783) This pattern is already used elsewhere
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 93.64% 94.17% +0.52%
==========================================
Files 32 33 +1
Lines 1196 1235 +39
Branches 193 206 +13
==========================================
+ Hits 1120 1163 +43
+ Misses 76 72 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the review. Generating docs appears to function now but the links are relative to my fork so I'll defer that. |
5dce66b
to
d57c5d7
Compare
Thank you! Sorry for the delay in merging this. I'll do a release after I get through a bit more of the PR queue |
New directive to control the encoding effort.
Users can specify efforts values that differ from the default effort for a given format.
PR?)
No
"min"
and"max"
keywords create a dependency on the format value in the metadata of the image. This was a compromise since specifying an exact number doesn't really make sense if you're generating multiple formats:e.g.
?format=webp;avif&effort=7
would mean webp effort is default since it is out of range.