Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add an exports map #404

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

benmccann
Copy link
Collaborator

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable - N/A there's no real way to write a test for this
  • Docs have been added / updated - N/A
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #402

  • What is the new behavior (if this is a feature change)?

Resolves .mjs files

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

This PR would only be breaking if a user is reaching into the internals of the package. That would become disallowed. However, I don't think there was every a reason to do that or that it's something that should be supported

  • Other information:

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

🦋 Changeset detected

Latest commit: 7e3723b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
imagetools-core Patch
rollup-plugin-imagetools Patch
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #404 (7e3723b) into main (a5d1fb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files          31       31           
  Lines        1097     1097           
  Branches      227      227           
=======================================
  Hits         1059     1059           
  Misses         38       38           
Flag Coverage Δ
imagetools-core 98.51% <ø> (ø)
rollup-plugin-imagetools 99.20% <ø> (ø)
vite-imagetools 84.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JonasKruckenberg JonasKruckenberg merged commit 60890de into JonasKruckenberg:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exports map
2 participants