-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ci, run on env, linter, move to poetry, chore, docs #3
feat: ci, run on env, linter, move to poetry, chore, docs #3
Conversation
Hi @JonasDoesThings, I know this PR is a bit big ;) feel free to ask any questions, suggestions, feedback, etc :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, great PR! Thanks for your work & contribution :)
Looks good overall, just a few question-marks on my end. I've added comments in the according places
README.md
Outdated
| Setting | Default | Description | | ||
|------------------------------|-------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| enabled | True | Whether the plugin is enabled when building your project. If you want to switch the plugin off, e.g. for local builds, use an [environment variables](https://www.mkdocs.org/user-guide/configuration/#environment-variables). | | ||
| enabled_on_serve | False | Whether the plugin is enabled when serving your project. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking myself if enabled_on_serve
would be a more "sane" default to prevent accidental leakage of unused assets by users that haven't read this plugin's documentation thoroughly, expecting the plugin to wipe these unused files away.
Open for input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, no, because serve in mkdocs is used only for local development purpose, and locally you do not care about orphaned files - its imported on the final build that goes for publishing.
Checking orphaned files on serve, just extends local development unnecessary. If someone really wanto to do it, then can enable it explicitly - and this is a purpose of enabled_on_serve
.
- ...
read this plugin's documentation
... actually it's a user problem ;) because its documented opposite to "no info in the docs at all".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just added more descriptive explanation to the docs.
I appreciate your responses, I will look over it again tomorrow after work, and merge it after trying it out locally :) |
Sorry for the late reply, life got in it's way. But I have merged it now! I've seen that the pyproject's version is set to 0.0.0 according to poetry-dynamic-versioning's recommendations. poetry-dynamic-versioning will automatically use the git tag version when building the package, is there anything else I need to keep in mind when doing that before releasing the new version to PyPi? Cheers! |
Hi @JonasDoesThings, no issue at all with time/contrib guide :)
|
Finally got this off my TODO list and published the new version 😅 Besides that everything seems fine and working, version 1.2.1 is published on PyPi now :) Cheers! 🎉 PS: poetry-dynamic-versioning is a real quality-of-life improvement 😄 |
@JonasDoesThings cool! For experiments, create clone of the repo, and use https://test.pypi.org/ for testing publish workflow :)
ps |
enabled
/enabled_on_serve
file_types_override_mode
: append, remove, replacepath.exists
for check -> solve issue on py3.8 and py3.9 on windowsmkdocs_exclude_unused_files
mkdocs-exclude-unused-files
exclude_unused_files
exclude-unused-files
<- picked up this one as default, to keep kinda of mkdocs plugins standard