Fix dag.multihash usage #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmanie
force-pushed
the
fix/ipfs-access-controller
branch
from
acf3ce6
to
7265aa9
Compare
|
Closed because this is due to a recent change in js-ipfs-http-client. js-ipfs and orbit-db have to catch up ipfs-inactive/js-ipfs-http-client#896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some issues with the usage of dag.multihash.
This line is wrong:
orbit-db/src/ipfs-access-controller.js
Line 41 in 73a67d9
It should be
hashnotmultihash: https://github.com/multiformats/js-cid/blob/22504757cead5e3213d6fd4a385ab546885debe8/src/index.js#L221. Also it's already a string.I found the same issue in
db-manifest.jsonFurthermore the error handling in the
savefunction was a little off. I hope it's a bit better now.