Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions for Safe Control actions #4194

Merged

Conversation

ArmandoGraterol
Copy link
Contributor

Updated conditionals, events, and messages to reflect that the user would need only the root permission to make safe control related actions.

FireShot Capture 810 - Safe transaction_ asdasda - Action - Colony - wonker - localhost
FireShot Capture 811 - Safe transaction_ asdasda - Action - Colony - wonker - localhost
FireShot Capture 812 - Add Safe from Ethereum - Action - Colony - wonker - localhost
FireShot Capture 813 - Remove Safe - Action - Colony - wonker - localhost

User with no root permission:
FireShot Capture 814 - Actions - Colony - wonker - localhost

Resolves #4192

@ArmandoGraterol ArmandoGraterol requested a review from a team February 9, 2023 13:45
@ArmandoGraterol ArmandoGraterol self-assigned this Feb 9, 2023
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working as expected, thanks @ArmandoGraterol

@ArmandoGraterol ArmandoGraterol merged commit 31fb27a into feature/gnosis-safe-control Feb 9, 2023
@ArmandoGraterol ArmandoGraterol deleted the bug/4192-safe-control-permissions branch February 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants