Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decisions: Handle Decisions heading formatting in preview & staking pages #3985

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

danbr
Copy link
Contributor

@danbr danbr commented Oct 13, 2022

Description

This PR fixes a bug when formatting of the Decision details is not consistently applied.

The heading formatting sets the text as <H3> and is displaying in the Decisions dialog as font size 16, but the same <H3> is displayed as font size 14 in preview & staking pages. The updates forces the <H3> to be font size 16 when displaying the Decision description.

I also added another small bug fix where a space is added before the button/link (and margin removed)

Screenshot 2022-10-13 at 21 52 06

Resolves #3980

@danbr danbr added the bug label Oct 13, 2022
@danbr danbr self-assigned this Oct 13, 2022
@danbr danbr requested a review from a team October 13, 2022 07:47
@danbr danbr marked this pull request as ready for review October 13, 2022 08:03
@danbr danbr mentioned this pull request Oct 13, 2022
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displaying the title correctly now.
Screenshot 2022-10-13 at 11 13 26

@danbr danbr merged commit 2309bc3 into feature/simple-decisions Oct 14, 2022
@danbr danbr deleted the fix/3980-preview-not-consistent branch October 14, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants