Fix: GasStationPopover causing horizontal overflow #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcolony
changed the title
chinins
approved these changes
Oct 12, 2022
Julianahlk
reviewed
Oct 13, 2022
There was a problem hiding this comment.
If this is the intended behavior then it looks good to me:
@jakubcolony can you confirm?
|
Hey @Julianahlk, I'm not 100% sure what you're showing - after opening the popover, are you resizing your browser window or is there something else going on? |
Julianahlk
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Hey @Julianahlk, I'm not 100% sure what you're showing - after opening the popover, are you resizing your browser window or is there something else going on?
I am not referring to the re sizing of the browser I was referring to the pop over's size. But disregard, I was looking at this issue really fast but It looks good 👍.
jakubcolony
force-pushed
the
fix/3781-gas-station-popover-overflow
branch
from
b970912 to
b1088c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue described in #3781. Unfortunately after spending good few hours on it I was unable to pinpoint what the issue is exactly (my bet is either Popper positioning not working properly or a Chrome-specific issue, since it doesn't occur in other browsers). After a call with @chinins I decided to amend the placement of the gas station popover so that it "faces away" from the right edge of the window and doesn't cause overflow:
The issue was quite tricky to reproduce in first place so here are the steps I followed:
You should see a horizontal overflow equal to roughly the width of the popover
Resolves #3781