Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent jumping of UI when displaying the transaction fee #3925

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Prevent jumping of UI when displaying the transaction fee #3925

merged 1 commit into from
Oct 3, 2022

Conversation

danbr
Copy link
Contributor

@danbr danbr commented Sep 29, 2022 •
edited
Loading

Description

Simple PR that prevents jumping when displaying the transaction fee.

Can be tested by:

  1. Go to create a payment dialog
  2. Add payment amount
  3. There shouldn't be any jumping.

Resolves #3774

@danbr danbr added the bug label Sep 29, 2022
@danbr danbr self-assigned this Sep 29, 2022
@danbr danbr requested a review from a team October 2, 2022 10:08
@danbr danbr marked this pull request as ready for review October 2, 2022 10:09
jakubcolony
jakubcolony approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No jumping anymore:

Screen.Recording.2022-10-03.at.11.54.23.mov

chinins
chinins approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@danbr danbr merged commit 992bfa1 into master Oct 3, 2022
@danbr danbr deleted the fix/3774-prevent-jumping-ui branch October 3, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubcolony jakubcolony jakubcolony approved these changes

@chinins chinins chinins approved these changes

Assignees

@danbr danbr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent jumping of UI when displaying the transaction fee
3 participants
@danbr @chinins @jakubcolony