Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activate button when part of tokens is activated #3776

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Add activate button when part of tokens is activated #3776

merged 4 commits into from
Aug 31, 2022

Conversation

chinins
Copy link
Contributor

@chinins chinins commented Aug 25, 2022 •
edited
Loading

Description

This PR:

  • adds another condition for activate button
  • fixes the rounding error for the stake button
  • moves back button to the left (UI is confirmed with Arren)

To replicate the bug, please, follow Arren's instructions from the issue.

resolves #3771

@chinins chinins added the bug label Aug 25, 2022
@chinins chinins self-assigned this Aug 25, 2022
@chinins chinins requested a review from a team August 25, 2022 14:51
@chinins chinins marked this pull request as ready for review August 25, 2022 14:51
danbr
danbr reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@danbr danbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinins I'm testing (with Arren's method) and wanna double check the behaviour with you, when you're free.

@chinins chinins requested a review from a team August 29, 2022 09:39
Julianahlk
Julianahlk approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@Julianahlk Julianahlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now working as expected 👍. Besides that, after creating a motion for the first time, I am getting a warning about the StakingWidget:
Screen Shot 2022-08-30 at 4 16 47 PM

ArmandoGraterol
ArmandoGraterol approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I wasn't able to replicate the rounding error on master but other than that the slider is working as expected

@chinins chinins force-pushed the fix/3771-fix-activate-button branch from a5eab4a to 8c682ea Compare August 31, 2022 18:25
@chinins chinins merged commit 908eca8 into master Aug 31, 2022
@chinins chinins deleted the fix/3771-fix-activate-button branch August 31, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbr danbr danbr left review comments

@Julianahlk Julianahlk Julianahlk approved these changes

@ArmandoGraterol ArmandoGraterol ArmandoGraterol approved these changes

Assignees

@chinins chinins

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to Stake full amount of available funds
4 participants
@chinins @danbr @ArmandoGraterol @Julianahlk