Sync single user picker with Address Book in award/smite dialogs

[willm30]

Description

This PR ensures that when the Address Book is enabled, the single user picker in the Award/Smite dialogs shows verified members instead of all members. When the Address Book is inactive, or no members have been added, the single user picker in both components should show all colony members.

Note: this was already happening in the Create Payment dialog. I have extracted this logic for reuse in the Award/Smite components.

To test:

1. With no members added, verify that the SingleUserPicker in the Award/Smite show all users in the colony.
2. Add a member or two to the address book. Now verify the SingleUserPicker only shows those members.
3. Turn off the address book. Now verify that the SingleUserPicker is showing all users again.

Changes 🏗

CreatePaymentDialog.tsx: Extracted the verifiedUsers logic for reuse in award/smite.
ManageReputationContainer.tsx: Added the ColonyMembers prop so that when the component loads, ColonyMembers is defined. This ensures that the selected user doesn't rerender after the component has been opened and therefore avoids a "flashing" in the ui. Also added the verifiedUsers logic.
ColonyHomeActions.tsx: I moved the ColonyMembers query here because this contains the loading component nearest to the ManageReputation Container.
useSelectedUser.ts: updated to take an array of AnyUser (making it compatible with an array of verified or subscribed users)

Additions

verifiedRecipients.ts: Extracted logic for filtering subscribed (i.e. all) users by whether they're verified or not.

Resolves #3641

Note: The issue says that this should apply to all SingleUserPicker instances however after checking this with Arren we agreed that it should only apply to the Payments and Award/Smite dialogs for now (see issue comments).

[danbr]

@willm30 Maybe my expectation is wrong?
The updates seem to be working except when I deactivate the address book. The list of potential awardees are still restricted.

Empty address book, with 1 contributor & 1 watcher

With User2 added to address book & deactivated

User options, expecting Dan & User2 to be displayed

[willm30]

@willm30 Maybe my expectation is wrong? The updates seem to be working except when I deactivate the address book. The list of potential awardees are still restricted.

@danbr Did you refresh the browser after deactivating the address book? For me, I need to do this first, then the updates propagate and the form shows all users. (Incidentally, I would like to open an issue to update the fetch-policies of the relevant queries so a browser refresh isn't needed after adding a member to the address book to see the updated address book).

[danbr]

@willm30 Maybe my expectation is wrong? The updates seem to be working except when I deactivate the address book. The list of potential awardees are still restricted.

@danbr Did you refresh the browser after deactivating the address book? For me, I need to do this first, then the updates propagate and the form shows all users. (Incidentally, I would like to open an issue to update the fetch-policies of the relevant queries so a browser refresh isn't needed after adding a member to the address book to see the updated address book).

@willm30 Thanks for the suggestion. I re-setup, and did several page refreshes and the behaviour remained the same with only 1 address shown. When she is available, i will ask @chinins to test, perhaps it will work for her.

[willm30]

@danbr Hmm, interesting. I am unable to reproduce. With a contributor and a watcher, I add the watcher to the address book, then deactivate the address book via the toggle switch, and after a browser refresh on the ColonyHome page I can see both users in the Award/Smite and CreatePayment dialogs.

This is where I implement the check for whether the whitelist is activated. It should pass the form (and therefore the Single User Picker) all users (i.e subscribedUsers) if isWhitelistActivated is false (even if there is a member added to the address book). Maybe you can spot something I'm overlooking?

[danbr]

@willm30 Finally, I deleted my local branch and now its behaving as expected, thankfully!! I'll review the code next....

[danbr]

Looks good. Working well..... Nice job.

[chinins]

As per my direct comments.

[willm30]

As per my direct comments.

@chinins Have updated and restored the Memebrs Query to the component. Please review when you get a moment.

[Julianahlk]

It works well for me!

[ArmandoGraterol]

Working as expected! Nice job

[chinins]

Very nice - much cleaner, I prefer it this way.