Ensure Gas Prices is at least 2 GWEI when on Gnosis Chain #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willm30
approved these changes
Jul 14, 2022
| @@ -97,18 +97,33 @@ const fetchGasPrices = async ( | |||
| // API prices are in Gwei, so they need to be normalised | |||
| const oneGwei = bigNumberify(10 ** 9); | |||
|
|
|||
| let { average } = data; | |||
| let { fast } = data; | |||
| /* | |||
There was a problem hiding this comment.
This could be written as
let { average, fast } = data;
ArmandoGraterol
approved these changes
Jul 14, 2022
rdig
force-pushed
the
maintenance/ensure-2gwei-gas-price
branch
from
46b3adf to
294bcc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly as it says on the tin, when on Gnosis Chain, if the gas estimate from the Oracle will be less than 2, set it to 2, otherwise, use the value from the Oracle.
This is to counteract transactions failing to be sent out, if the Gas paid was lower.
Granted this should't be that much of a problem anymore, with the advent of Metatransactions, but since we've been running this code in production since before the Token Sale, might as well merge it in.