Fix: Updated logic for funds links #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willm30
requested changes
Jul 13, 2022
| const allUserRoles = useTransformer(getAllUserRoles, [colony, walletAddress]); | ||
|
|
||
| const canMoveFunds = !!username && !ethereal && canFund(allUserRoles); | ||
| const canMoveFunds = !!username && !ethereal; | ||
|
|
||
| const { | ||
| colonyAddress, |
There was a problem hiding this comment.
Line 60 below canMoveFunds ? ... is the logic that needs to be removed.
There was a problem hiding this comment.
Got it! Thanks Will.
rdig
previously requested changes
Jul 13, 2022
There was a problem hiding this comment.
Agree with Will, the link disabling / enabling works fine, however the link to the Manage Funds page does not.
Here's with a logged out user (it should work for that case as well)
Note that the incoming funds section works correctly, and even point to the same location. So you can just copy/paste it's logic
While after being logged in, it works correctly
It should be working now. Thank you! |
Julianahlk
force-pushed
the
fix/3550-inactive-links-on-funds-page
branch
from
d84f995 to
e57ac6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the "Available Funds" link that should take the user to the funds page and be enabled regardless of permissions but it is currently inactive.
Additionally, once you go inside the funds page, the Move funds, Mint Tokens, Manage Tokens links should all be active depending on the following:
Changes 🏗
TODO
Resolves #3550