Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Input names for validation messages #3606

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Julianahlk
Copy link
Contributor

Description

Validation message should match the input field label.

Changes 🏗

  • Updated input fields to match their respective validation messages.

inputvalidmsg

Resolves #3583

@Julianahlk Julianahlk marked this pull request as ready for review July 8, 2022 20:03
@Julianahlk Julianahlk requested a review from a team July 8, 2022 20:03
Copy link
Collaborator

@willm30 willm30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

Copy link
Contributor

@danbr danbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - working well. Good job.....

@willm30
Copy link
Collaborator

willm30 commented Jul 12, 2022

Now I think about it, I think that the error message should probably read something like "Please enter a value", as on this branch: #3607. For another day...

@Julianahlk
Copy link
Contributor Author

Now I think about it, I think that the error message should probably read something like "Please enter a value", as on this branch: #3607

@willm30 I don't see the error message you are referring to in the other branch you mentioned above but I am assuming you want a more user friendly error message?

Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@Julianahlk Julianahlk force-pushed the fix/3583-create-colony-validation-msgs branch from 90464e6 to 09f3ee7 Compare July 13, 2022 18:04
@Julianahlk Julianahlk merged commit 97472cb into master Jul 13, 2022
@Julianahlk Julianahlk deleted the fix/3583-create-colony-validation-msgs branch July 13, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: create-colony validation messages should align with labels
4 participants