Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Changed the colonies list scroll to a fixed position #3569

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix: Changed the colonies list scroll to a fixed position #3569

merged 2 commits into from
Jul 5, 2022

Conversation

Julianahlk
Copy link
Contributor

Description

The colonies list (right side of screen) should be static no matter how many colonies you've subscribed to.

Changes 🏗

  • The colonies list was changed to a fixed position

colony

Resolves #3553

@Julianahlk
Copy link
Contributor Author

Julianahlk commented Jun 30, 2022 •
edited
Loading

Screen Shot 2022-06-30 at 8 41 05 PM

The above is an issue because of the negative margin. Does it make sense to fix this overlapping of the colony name and address in this PR or should we deferred this to the mobile responsiveness tasks as this only happens in smaller screen sizes?

@Julianahlk Julianahlk marked this pull request as ready for review June 30, 2022 19:07
@Julianahlk Julianahlk requested a review from a team June 30, 2022 19:07
@willm30
Copy link
Collaborator

willm30 commented Jun 30, 2022

The above is an issue because of the negative margin. Does it make sense to fix this overlapping of the colony name and address in this PR or should we deferred this to the mobile responsiveness tasks as this only happens in smaller screen sizes?

I wouldn't say it belongs in mobile responsiveness as the screen size you're showing in the screenshot wouldn't be considered mobile. Mobile is currently 768px and under, with plans to ensure the dapp responds nicely at breakpoints 980 and 1200 also.

willm30
willm30 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@willm30 willm30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended!

@willm30
Copy link
Collaborator

willm30 commented Jun 30, 2022

The above is an issue because of the negative margin. Does it make sense to fix this overlapping of the colony name and address in this PR or should we deferred this to the mobile responsiveness tasks as this only happens in smaller screen sizes?

Probably worth creating a separate issue for it.

@Julianahlk Julianahlk self-assigned this Jun 30, 2022
@Julianahlk
Copy link
Contributor Author

Probably worth creating a separate issue for it.

Okay, I can do that. Thanks for the suggestion.

@arrenv
Copy link
Member

arrenv commented Jul 1, 2022 •
edited
Loading

The above is an issue because of the negative margin. Does it make sense to fix this overlapping of the colony name and address in this PR or should we deferred this to the mobile responsiveness tasks as this only happens in smaller screen sizes?

I think it is worth fixing in this PR, save the extra paper work. Also, because this PR introduces the issue.

arrenv
arrenv approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the issue with the ColonyTitle, this looks good to me.

@Julianahlk
Copy link
Contributor Author

Other then the issue with the ColonyTitle, this looks good to me.

Thanks Arrren! I will make the change of the ColonyTitle in this PR as well.

@Julianahlk Julianahlk force-pushed the feature/3553-colonies-list-scroll-static branch from e83095d to 345c2b2 Compare July 5, 2022 11:15
@Julianahlk Julianahlk force-pushed the feature/3553-colonies-list-scroll-static branch from 345c2b2 to 8e1a0c0 Compare July 5, 2022 12:19
@Julianahlk Julianahlk merged commit 0c09d0d into master Jul 5, 2022
@Julianahlk Julianahlk deleted the feature/3553-colonies-list-scroll-static branch July 5, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willm30 willm30 willm30 approved these changes

@arrenv arrenv arrenv approved these changes

Assignees

@Julianahlk Julianahlk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colonies list scrolls with page
3 participants
@Julianahlk @willm30 @arrenv