Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Remove BetaCautionAlert #3554

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Feat: Remove BetaCautionAlert #3554

merged 1 commit into from
Jun 29, 2022

Conversation

Julianahlk
Copy link
Contributor

@Julianahlk Julianahlk commented Jun 29, 2022 •
edited
Loading

Description

This PR removes the BETA alert that appears in the footer of the DApp.

Changes 🏗

  • Removed the BetaCautionAlert component and removed all instances where this component was used.

Deletions ⚰️

  • BetaCautionAlert component.

Resolves #3554

@Julianahlk Julianahlk requested a review from a team June 29, 2022 08:42
@willm30
Copy link
Collaborator

willm30 commented Jun 29, 2022

FYI this PR is still in draft mode but when you select people for review it notifies them straightaway so best to wait until after you've clicked Ready for review 🙂

@Julianahlk Julianahlk marked this pull request as ready for review June 29, 2022 09:24
@Julianahlk
Copy link
Contributor Author

Julianahlk commented Jun 29, 2022 •
edited
Loading

@willm30 Good to know! Thank you

FYI this PR is still in draft mode but when you select people for review it notifies them straightaway so best to wait until after you've clicked Ready for review 🙂

This PR is actually ready but I forgot to click the ready for review button earlier. 😅

@Julianahlk Julianahlk self-assigned this Jun 29, 2022
@Julianahlk Julianahlk added feature good-first-issue Issues that will help you get acquainted with the Dapp labels Jun 29, 2022
@willm30
Copy link
Collaborator

willm30 commented Jun 29, 2022

Also don't forget to link the PR to the correct issue at the bottom, e.g. Resolves #1234 🙂

willm30
willm30 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@willm30 willm30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rdig
Copy link
Member

rdig commented Jun 29, 2022

@Julianahlk

Screenshot from 2022-06-29 13-40-25

Don't label PRs, just issues.

Since the issue has the correct labels, and the PR is attached to the issue (as Will pointed out above), there's no point in re-labeling

rdig
rdig approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Good to go! 👍

@Julianahlk Julianahlk merged commit 7bc6327 into master Jun 29, 2022
@Julianahlk Julianahlk deleted the maintenance/3525-remove-beta-alert branch June 29, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willm30 willm30 willm30 approved these changes

@rdig rdig rdig approved these changes

Assignees

@Julianahlk Julianahlk

Labels
feature good-first-issue Issues that will help you get acquainted with the Dapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julianahlk @willm30 @rdig