Resolves confusing characters & warnings #3389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates colonyDapp to use
@colony/unicode-confusables-noascii
. As the name suggests, the new package does not include ascii characters (numbers are still considered) in its ruleset.Therefore, 'm' & 'l' will not be considered worthy of a warning.
A more detailed explanation, and the hidden part of this PR:
The package unicode-confusable has a script that at build time, takes the official unicode definitions (https://unicode.org/Public/security/10.0.0/confusables.txt) and extracts to confusables.json which is then distributed within the NPM and used as the source of its decisions of confusability.
Steps followed:
This approach should be more inline with Metamask and other users of confusable, and hopefully requires less maintenance in the future. Part of which can be 'piggybacked' from unicode-confusable
Resolves #3268