-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members list update: contributors vs. watchers #3376
Conversation
9f9ddd7
to
55beae3
Compare
Heads up to @chinins and whoever else might care :) I've removed Sayan's erroneous commit and reverted the branch back to it's previous state |
Big mistake on my part, sorry! |
bdc0d79
to
ec6e018
Compare
297ac80
to
1902c60
Compare
7eeb053
to
90b209a
Compare
19dcf92
to
d154aba
Compare
d154aba
to
3f9ecc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! All looking good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @chinins and the rest of the team that contributed to this. 💯
I've left some notes to things that stuck out, but nothing major. As far as I'm concerned this is good to merge.
src/modules/dashboard/components/ColonyHome/ColonyMembers/MembersSubsection.tsx
Show resolved
Hide resolved
src/modules/dashboard/components/ColonyHome/ColonySubscription/ColonySubscription.tsx
Show resolved
Hide resolved
src/modules/dashboard/components/ColonyMembers/MemberControls/MemberControls.tsx
Show resolved
Hide resolved
3f9ecc6
to
34985ba
Compare
Story
As a colony owner, I would like to recognize who is the admin of a team, so I can find quickly who is accountable for administrative decisions.
As a colony admin, I would like to find someone new I can assign to an onboarding task, so this person could earn reputation.
As a new community member, I would like to watch what is happening within a colony, so if interesting task appears I could contribute.
Description
There is no distinction of users who hold permissions and reputation and those who do not. By introducing a separation of members and watchers, we make it easier to recognize who is team member and who is just watching a colony.
Which, can also make it easier to find users to perform actions and tasks.
Figma: https://www.figma.com/file/qQoBbyyDXkuHwoqHIOGjEu/Colony-Simplified?node-id=6736%3A90572
Notion doc with details
https://www.notion.so/colony/Contributors-v-Watchers-be2bb5c9c87b4cb5bf1c734f88ee1466