Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members list update: contributors vs. watchers #3376

Merged
merged 120 commits into from
Jul 15, 2022

Conversation

chinins
Copy link
Contributor

@chinins chinins commented May 10, 2022

Story

As a colony owner, I would like to recognize who is the admin of a team, so I can find quickly who is accountable for administrative decisions.

As a colony admin, I would like to find someone new I can assign to an onboarding task, so this person could earn reputation.

As a new community member, I would like to watch what is happening within a colony, so if interesting task appears I could contribute.

Description

There is no distinction of users who hold permissions and reputation and those who do not. By introducing a separation of members and watchers, we make it easier to recognize who is team member and who is just watching a colony.

Which, can also make it easier to find users to perform actions and tasks.

Figma: https://www.figma.com/file/qQoBbyyDXkuHwoqHIOGjEu/Colony-Simplified?node-id=6736%3A90572

Notion doc with details
https://www.notion.so/colony/Contributors-v-Watchers-be2bb5c9c87b4cb5bf1c734f88ee1466

@rdig
Copy link
Member

rdig commented May 17, 2022

I see this is the feature branch, @dit7ya why did you commit directly into it? 9f9ddd7

@rdig rdig force-pushed the feature/contributors-vs-watchers branch from 9f9ddd7 to 55beae3 Compare May 17, 2022 12:50
@rdig
Copy link
Member

rdig commented May 17, 2022

Heads up to @chinins and whoever else might care :)

I've removed Sayan's erroneous commit and reverted the branch back to it's previous state

@dit7ya
Copy link
Contributor

dit7ya commented May 17, 2022

Big mistake on my part, sorry!

@chinins chinins force-pushed the feature/contributors-vs-watchers branch from bdc0d79 to ec6e018 Compare June 9, 2022 12:55
@chinins chinins force-pushed the feature/contributors-vs-watchers branch from 297ac80 to 1902c60 Compare June 22, 2022 20:07
@chinins chinins force-pushed the feature/contributors-vs-watchers branch 2 times, most recently from 7eeb053 to 90b209a Compare July 12, 2022 13:59
@chinins chinins force-pushed the feature/contributors-vs-watchers branch from 19dcf92 to d154aba Compare July 15, 2022 10:07
@chinins chinins requested a review from a team July 15, 2022 10:32
@chinins chinins marked this pull request as ready for review July 15, 2022 10:32
@chinins chinins force-pushed the feature/contributors-vs-watchers branch from d154aba to 3f9ecc6 Compare July 15, 2022 10:34
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! All looking good :)

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @chinins and the rest of the team that contributed to this. 💯

I've left some notes to things that stuck out, but nothing major. As far as I'm concerned this is good to merge.

chinins added 27 commits July 15, 2022 20:09
@chinins chinins force-pushed the feature/contributors-vs-watchers branch from 3f9ecc6 to 34985ba Compare July 15, 2022 17:10
@chinins chinins merged commit 1106900 into master Jul 15, 2022
@chinins chinins deleted the feature/contributors-vs-watchers branch July 15, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants