Display important copy to warn about Award Reputation #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdig
approved these changes
May 3, 2022
| </div> | ||
| </DialogSection> | ||
| {!isSmiteAction && <hr className={styles.divider} />} |
There was a problem hiding this comment.
Not a big fan of hr elements, but you used it correctly in this instance, so I can't even nit pick it :P
ArmandoGraterol
approved these changes
May 3, 2022
chinins
approved these changes
May 5, 2022
danbr
force-pushed
the
feat/3337-add-copy-award-reputation
branch
from
19b975a to
f497266
Compare
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR displays copy to warn about exercising caution when using Award Reputation (not shown on Smite dialog).
I added a few extra minor fixes that were bothering me as i frequently navigated to the dialog. These include:
1- (Award) reputation should be capitalised
2- Smite should be 'Smite Reputation'
3- Within the descriptions capitalisation of 'reputation' should consistent
4-(in Smite dialog) Title currently 'Smite' should be 'Smite Reputation'
Resolves #3337