Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old member rep being weird on motion page #3288

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

ArmandoGraterol
Copy link
Contributor

Fixed MemberReputation on the motion page not using the motion's root hash for the total domain reputation, and not using a dynamic domain id (It was always using the root domain id to get the rep).

Now the reputation shown on the motion page should be consistent with the rep that the users had at the time of the motion creation and not change percentages when the user gets more or less reputation.

Resolves #3249

@ArmandoGraterol ArmandoGraterol requested a review from a team April 4, 2022 20:39
@ArmandoGraterol ArmandoGraterol self-assigned this Apr 4, 2022
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, works for me!

Before

c1c3474f-139b-4749-99ab-8d67586d311c

Before after refresh

download (28)

After on navigate and after refresh

download (29)

Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

Copy link
Contributor

@dit7ya dit7ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I was so baffled by this - turns out the solution is elegant and simple.

Before After
Screenshot 2022-04-05 at 16-36-04 Pay halum 54 NCC Motion Colony - Notun Screenshot 2022-04-05 at 16-36-04 Pay halum 54 NCC Motion Colony - Notun

@ArmandoGraterol ArmandoGraterol force-pushed the bug/issue-3249-motion-user-reputation branch from d3ff7a6 to d9438ee Compare April 5, 2022 19:27
@ArmandoGraterol ArmandoGraterol merged commit 5494cec into master Apr 5, 2022
@ArmandoGraterol ArmandoGraterol deleted the bug/issue-3249-motion-user-reputation branch April 5, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User reputation on motion page is acting funny
4 participants