Incorporate network fees in Create Payment

[dit7ya]

Description

This PR

• displays the network fee in Create Payment Dialog
• Calls the network contract with the total amount (amount to be received + fees) so that the recipient simply gets the amount typed in the form.

Resolves #3266.

[ArmandoGraterol]

I like this change! It should definitely improve the UX

Something weird is happening tho:

The amount shown in event and action list is different from the amount in the action page

[dit7ya]

Good point @ArmandoGraterol. Fixed that in the last commit.

One point worth noting is that now there is no easy way for the payment initiator to know exactly how much they spent on a payment including fees.

[chinins]

It looks ok, I just have a question about come number calculations.

[arrenv]

The appearance seems off when comparing to the design. There is no colon punctuation mark in the design, the font is more consistent in weight and size, and is closer to the the input field. See following comparison.

[dit7ya]

@arrenv Thanks for the comments.

I will change the font weight. However, IMO the colon is consistent with the Available Funds subtitle. What do you think?

About the spacing - it is the same spacing as the Available Funds subtitle (which is also not following the spec). Do you want me to change both? If yes, what do you suggest to deal with the conflict with the insufficient balance warning?

[arrenv]

IMO the colon is consistent with the Available Funds subtitle. What do you think?

I agree with you, good observation.

About the spacing - it is the same spacing as the Available Funds subtitle (which is also not following the spec). Do you want me to change both? If yes, what do you suggest to deal with the conflict with the insufficient balance warning?

Another good pickup. It seems there is no decided solution for this after to chatting to Karol. One idea though was to have only one visible at a time, i.e. either the error message or the sub-text be visible at any given time. Although, that would be a separate issue to this. For the purpose of this PR, what you have makes sense.

[ArmandoGraterol]

Now the amount shown in the action list seems to be after fees so good work! However, I still found something that might be confusing:

I paid myself 10 and 11 tokens, when I went to the action page or to the token activation popover I see that it's shown as 9.9999... and 10.999... which is a different amount than what we show in the action list.

So from this, I have questions, is the amount shown on the action page/token activation popover the real value, and the one shown in the action list is rounded up? Or is the value in the action page/token activation popover wrong?

[arrenv]

@dit7ya Yeah, I am seeing the same as Armando, it seems as though it has reverted back to how it was originally. And ignoring the fee, despite showing it.

[dit7ya]

@ArmandoGraterol I will take a look at the rounding tomorrow and do the needful. @arrenv What do you mean by it has gone back to how it was? I did some tests and it seems like it is just the rounding error of 0.00001 instead of 1% decrease like before.

[arrenv]

@ArmandoGraterol I will take a look at the rounding tomorrow and do the needful. @arrenv What do you mean by it has gone back to how it was? I did some tests and it seems like it is just the rounding error of 0.00001 instead of 1% decrease like before.

I think it is just to do with the rounding errors.

[dit7ya]

@ArmandoGraterol @arrenv Figured that out. It was happening because the contract adds an extra 1 Wei of fee after the percentage calculation. For large amounts it was getting rounded in the UI (but not actually in the wallet balance).

Changed the calculation equation and it should be good now.

[arrenv]

Working for me now, nice work!

[ArmandoGraterol]

Nice work! It's looking good in every place that I could check

[chinins]

Looking good now - nice work!