Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent extra margin in DefaultMotion tags #3254

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Prevent extra margin in DefaultMotion tags #3254

merged 1 commit into from
Mar 22, 2022

Conversation

dit7ya
Copy link
Contributor

@dit7ya dit7ya commented Mar 21, 2022

Description

I the cause of the issue is https://github.com/joincolony/colonyDapp/blob/f09568540a45c9a29aea6fb49061ca796344ddc7/src/modules/core/components/Tag/Tag.css#L11

  • the sibling selector kicks in when there are two tags in the same line - even if there is text in between them.

In DefaultMotion wrapping the Tag component in a span prevents that from happening.

Screenshot 2022-03-21 at 11-10-59 Pay halum 199 TOK Motion Colony - Notun

Resolves #3253

@dit7ya dit7ya added the bug label Mar 21, 2022
@dit7ya dit7ya requested a review from a team March 21, 2022 05:49
@dit7ya dit7ya self-assigned this Mar 21, 2022
@arrenv
Copy link
Member

arrenv commented Mar 21, 2022

@dit7ya Looks good, the fix looks to be working for me.

Before

download (24)

After

download (23)

ArmandoGraterol
ArmandoGraterol approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

chinins
chinins approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

danbr
danbr approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@danbr danbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@dit7ya dit7ya merged commit 8118a3c into master Mar 22, 2022
@dit7ya dit7ya deleted the fix/3253-motion-message-tag-margins branch March 22, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinins chinins chinins approved these changes

@arrenv arrenv arrenv approved these changes

@ArmandoGraterol ArmandoGraterol ArmandoGraterol approved these changes

@danbr danbr danbr approved these changes

Assignees

@dit7ya dit7ya

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve placement of tag in fully staked Motion message
5 participants
@dit7ya @arrenv @danbr @ArmandoGraterol @chinins