Enhance the management of 'confirm' button state in components that use TokenSelector & update copy #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicjakujawa
suggested changes
Jan 31, 2022
src/modules/dashboard/components/CreateColonyWizard/TokenSelector.tsx
Outdated
Show resolved
Hide resolved
arrenv
approved these changes
Feb 1, 2022
chinins
reviewed
Feb 2, 2022
src/modules/dashboard/components/CreateColonyWizard/StepSelectToken.tsx
Outdated
Show resolved
Hide resolved
chinins
approved these changes
Feb 2, 2022
danbr
changed the title
ArmandoGraterol
approved these changes
Feb 3, 2022
alicjakujawa
approved these changes
Feb 7, 2022
danbr
force-pushed
the
bug/3121-manage-token-button-state
branch
from
48bba1c to
f009a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds corrects the behavior of
TokenEditDialog, and updates the copy to read "Token data not found. Please check the token contract address.".A new callback prop to
TokenSelectorwas added to inform the caller of when an address is being searched.Initially,
TokenEditDialogwas enhanced to guard the 'confirm' button when performing verification & validation. But 2 other components (UserTokenEditDialogForm&StepSelectToken) that useTokenSelectoralso had the same issues, so they were also updated.Before updates:
After updates:
Resolves #3121