-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show full colony name while creating colony #3130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dit7ya looks much better, nice one.
What are your thoughts on the character limits? I feel that they could be increased to have a max of 2 lines. You could also add in a word-break: break-word;
for long strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be working as expected!
@arrenv raised a valid point, perhaps it could be beneficial to bring this up to Product to see what they think about increasing the limit, leaving it as it is, or breaking the words/sentence.
And about the normalization function, it seems like it comes from quite old code so I would consult with @rdig first to know what does it do, and if it's still needed before removing it
@arrenv @ArmandoGraterol I have no opinion on truncation length. However, I feel like if it is a very long name, there should be some visual indication (like bold font) for the colony name. Adding word-break seems like a good idea irrespective of the above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that displayName will always exist? Shouldn't we fallback to colonyName?
@alicjakujawa I cannot think of a scenario of creating the colony without a full name. Does not the following make it required? If you want I can make it fallback to colonyName nonetheless. |
a59ea26
to
049f298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
049f298
to
e95917d
Compare
Description
Shows full colony name instead of ENS name in the Create Colony Wizard.
Note to reviewers
Resolves #3128.